Skip to content

Remove fsgroup from alluxio runtime #3635

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
fluid-e2e-bot merged 3 commits into from
Dec 18, 2023
Merged

Remove fsgroup from alluxio runtime #3635

fluid-e2e-bot merged 3 commits into from
Dec 18, 2023

Conversation

@cheyang
Copy link
Collaborator

@cheyang cheyang commented Dec 12, 2023

Ⅰ. Describe what this PR does

Ⅱ. Does this pull request fix one issue?

fixes #XXXX

Ⅲ. List the added test cases (unit test/integration test) if any, please explain if no tests are needed.

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cheyang
Remove fsgroup from alluxio runtime, To #53506158
33bdcd0 
Signed-off-by: cheyang <cheyang@163.com>
@codecov
Copy link

codecov bot commented Dec 12, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (330e0f4) 64.27% compared to head (4aef92b) 64.26%.
Report is 8 commits behind head on master.

❗ Current head 4aef92b differs from pull request most recent head ac09456. Consider uploading reports for the commit ac09456 to get more accurate results

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #3635      +/-   ##
==========================================
- Coverage   64.27%   64.26%   -0.01%     
==========================================
  Files         443      443              
  Lines       26739    26747       +8     
==========================================
+ Hits        17187    17190       +3     
- Misses       7540     7542       +2     
- Partials     2012     2015       +3

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cheyang
Remove fsgroup from alluxio runtime, To #53506158
4aef92b 
Signed-off-by: cheyang <cheyang@163.com>
@cheyang
Remove fsgroup from alluxio runtime, To #53506158
ac09456 
Signed-off-by: cheyang <cheyang@163.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 12, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@cheyang
Copy link
Collaborator Author

cheyang commented Dec 12, 2023

/test fluid-e2e

TrafalgarZZZ
TrafalgarZZZ approved these changes Dec 18, 2023
View reviewed changes
Copy link
Member

@TrafalgarZZZ TrafalgarZZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@fluid-e2e-bot fluid-e2e-bot bot added the lgtm label Dec 18, 2023
@fluid-e2e-bot
Copy link

fluid-e2e-bot bot commented Dec 18, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: TrafalgarZZZ

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fluid-e2e-bot fluid-e2e-bot bot merged commit 3d443d8 into fluid-cloudnative:master Dec 18, 2023
cheyang added a commit to cheyang/fluid that referenced this pull request Dec 19, 2023
@cheyang
Remove fsgroup from alluxio runtime (fluid-cloudnative#3635)
6d72c1c 
* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

---------

Signed-off-by: cheyang <cheyang@163.com>
cheyang added a commit that referenced this pull request Dec 21, 2023
@cheyang
Remove fsgroup from alluxio runtime (#3635) (#3654)
e43fb0c 
* Remove fsgroup from alluxio runtime, To #53506158



* Remove fsgroup from alluxio runtime, To #53506158



* Remove fsgroup from alluxio runtime, To #53506158



---------

Signed-off-by: cheyang <cheyang@163.com>
xliuqq pushed a commit to xliuqq/fluid that referenced this pull request Dec 23, 2023
@cheyang @xliuqq
Remove fsgroup from alluxio runtime (fluid-cloudnative#3635)
a9edbc3 
* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

* Remove fsgroup from alluxio runtime, To #53506158

Signed-off-by: cheyang <cheyang@163.com>

---------

Signed-off-by: cheyang <cheyang@163.com>
@cheyang cheyang deleted the remove_alluxio_fsgroup branch January 17, 2025 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TrafalgarZZZ TrafalgarZZZ TrafalgarZZZ approved these changes

@xliuqq xliuqq Awaiting requested review from xliuqq

Assignees

@TrafalgarZZZ TrafalgarZZZ

Labels

approved lgtm

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@cheyang @TrafalgarZZZ