-
Notifications
You must be signed in to change notification settings - Fork 731
Improves the subject identification for chained assertions and those that use Which #3000
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
aeb55e4 to
b4d656c
Compare
Pull Request Test Coverage Report for Build 13194283284Details
💛 - Coveralls |
b4d656c to
e477149
Compare
jnyrup
reviewed
Feb 5, 2025
Tests/FluentAssertions.Specs/Execution/CallerIdentificationSpecs.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/CallerIdentification/WhichParsingStrategy.cs
Outdated
Show resolved
Hide resolved
Src/FluentAssertions/CallerIdentification/WhichParsingStrategy.cs
Outdated
Show resolved
Hide resolved
e477149 to
759e8d4
Compare
jnyrup
approved these changes
Feb 6, 2025
Member
jnyrup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remember to update release notes
759e8d4 to
0f22dc4
Compare
jnyrup
added a commit
to jnyrup/fluentassertions
that referenced
this pull request
Feb 27, 2025
Fixes fluentassertions#3031 Regression from fluentassertions#3000 where previously `getCallerIdentifier() + callerPostfix` would return an empty string.
7 tasks
This was referenced Jul 21, 2025
This was referenced Dec 31, 2025
This was referenced Jan 7, 2026
This was referenced Jan 14, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given the following chained assertion
If the second
ContainSingle, fails, this PR ensures that the subject is displayed ascollection[0].Parameters[0].This required several changes to make this possible:
CallerIdentifierhas received a new methodDetermineCallerIdentitiesthat extracts all subjects from a chained assertion like the one above.AssertionChaindelegates tracking which subject to use for its failures using a newSubjectIdentificationBuilderclass. This one also takes into account any ambientAssertionScopes and modifications thatWhichdoes to the subject/CallerIdentifierandCallerStatementBuilderare really not correct, but I've decided to keep that out of this PR.Fixes #2747
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcome