-
Notifications
You must be signed in to change notification settings - Fork 731
Simplify FrameworkSpecs #2712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
dennisdoomen
merged 1 commit into
fluentassertions:develop
from
0xced:simplify-FrameworkSpecs
Aug 3, 2024
Merged
Simplify FrameworkSpecs #2712
dennisdoomen
merged 1 commit into
fluentassertions:develop
from
0xced:simplify-FrameworkSpecs
Aug 3, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While it makes sense not to take hard dependencies on test frameworks in the FluentAssertions library, the TestFrameworks specs all have a dependency on the their respective test frameworks. Use them to simplify the assertion on the exceptions which should be thrown. Note that the support for NUnit4 was introduced exactly like this in 2f56211.
Qodana for .NETIt seems all right 👌 No new problems were found according to the checks applied 💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
Pull Request Test Coverage Report for Build 10226220533Details
💛 - Coveralls |
jnyrup
approved these changes
Aug 3, 2024
dennisdoomen
approved these changes
Aug 3, 2024
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Aug 21, 2024
This reverts commit feb3147.
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Aug 21, 2024
This reverts commit feb3147 and add a comment explaining why the exception types must not be referenced explicitly.
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Sep 4, 2024
This reverts commit feb3147 and add a comment explaining why the exception types must not be referenced explicitly.
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Sep 13, 2024
This reverts commit feb3147 and add a comment explaining why the exception types must not be referenced explicitly.
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Oct 27, 2024
This reverts commit feb3147 and add a comment explaining why the exception types must not be referenced explicitly.
0xced
added a commit
to 0xced/fluentassertions
that referenced
this pull request
Oct 28, 2024
This reverts commit feb3147 and add a comment explaining why the exception types must not be referenced explicitly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT
./build.sh --target spellcheckor.\build.ps1 --target spellcheckbefore pushing and check the good outcomeDescription
While it makes sense not to take hard dependencies on test frameworks in the FluentAssertions library, the TestFrameworks specs all have a dependency on the their respective test frameworks. Use them to simplify the assertion on the exceptions which should be thrown.
Note that the support for NUnit4 was introduced exactly like this in 2f56211.