Skip to content

Remove .NET Core 2.1.x and 3.1.x from build SDK setup #2467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Nov 16, 2023
Merged

Remove .NET Core 2.1.x and 3.1.x from build SDK setup #2467

dennisdoomen merged 1 commit into from
Nov 16, 2023

Conversation

@ITaluone
Copy link
Contributor

@ITaluone ITaluone commented Nov 16, 2023

Since we do not support .NET Core 2.1.x and 3.1.x anymore nor test against this TFMs I think we don't need to set them up in the build pipline.

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@github-actions
Copy link

github-actions bot commented Nov 16, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@coveralls
Copy link

coveralls commented Nov 16, 2023

Pull Request Test Coverage Report for Build 6887736004

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 97.457%
Totals Coverage Status
Change from base Build 6887225049: 0.0%
Covered Lines: 11743
Relevant Lines: 11926
💛 - Coveralls

@dennisdoomen dennisdoomen merged commit 95010ce into fluentassertions:develop Nov 16, 2023
@ITaluone ITaluone deleted the remove-net-sdk-setup branch November 16, 2023 11:06
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Dec 19, 2024
@ITaluone @jnyrup
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (fluentassertio…
23d23cb 
…ns#2467)
jnyrup pushed a commit that referenced this pull request Dec 20, 2024
@ITaluone @jnyrup
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (#2467)
20215aa
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Feb 1, 2025
@ITaluone @jnyrup
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (fluentassertio…
978f395 
…ns#2467)
jnyrup pushed a commit that referenced this pull request Feb 1, 2025
@ITaluone @jnyrup
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (#2467)
e2e0ce2
ScarletKuro referenced this pull request in AwesomeAssertions/AwesomeAssertions Feb 8, 2025
@ITaluone @ScarletKuro
Remove .NET Core 2.1.x and 3.1.x from build SDK setup (#2467)
0ee09c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@ITaluone @coveralls @dennisdoomen @jnyrup