Skip to content

Added more date/time tips #2435

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Nov 4, 2023
Merged

Added more date/time tips #2435

dennisdoomen merged 1 commit into from
Nov 4, 2023

Conversation

@Meir017
Copy link
Member

@Meir017 Meir017 commented Nov 3, 2023 •
edited
Loading

resolves #2433

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@Meir017 Meir017 force-pushed the docs/datetime-tips branch from 0b8c79b to 929fd7b Compare November 3, 2023 12:04
@Meir017 Meir017 changed the title Docs: datetime tips docs: datetime tips Nov 3, 2023
@github-actions
Copy link

github-actions bot commented Nov 3, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.8
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@dennisdoomen dennisdoomen changed the title docs: datetime tips Added more date/time tips Nov 3, 2023
@dennisdoomen dennisdoomen requested a review from jnyrup November 3, 2023 18:47
@dennisdoomen dennisdoomen enabled auto-merge (squash) November 3, 2023 18:47
jnyrup
jnyrup approved these changes Nov 4, 2023
View reviewed changes
docs/_data/tips/datetimes.yml
Comment on lines +43 to +47
old-message: |
Did not expect the year part of actual to be 2017, but it was.
new-message: |
Did not expect actual.Year to be 2017.
Copy link
Member

@jnyrup jnyrup Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
old-message: |
Did not expect the year part of actual to be 2017, but it was.
new-message: |
Did not expect actual.Year to be 2017.
old-message: |
Did not expect actual.Year to be 2017.
new-message: |
Did not expect the year part of actual to be 2017, but it was.

Copy link
Member

@jnyrup jnyrup Nov 4, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ahh... didn't spot the auto-merge 🤦‍♂️

@dennisdoomen dennisdoomen merged commit 593591a into fluentassertions:develop Nov 4, 2023
@Meir017 Meir017 deleted the docs/datetime-tips branch November 4, 2023 18:17
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@Meir017 @jnyrup
add datetime tips for date parts (fluentassertions#2435)
e2b1974
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@Meir017 @jnyrup
add datetime tips for date parts (fluentassertions#2435)
ff296b0
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@Meir017 @jnyrup
add datetime tips for date parts (fluentassertions#2435)
ac55522
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@Meir017 @jnyrup
add datetime tips for date parts (fluentassertions#2435)
7e6a661
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@Meir017 @jnyrup
add datetime tips for date parts (fluentassertions#2435)
cffffa7
jnyrup pushed a commit that referenced this pull request Sep 9, 2024
@Meir017 @jnyrup
add datetime tips for date parts (#2435)
02ebfa2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

@dennisdoomen dennisdoomen dennisdoomen approved these changes

Assignees

No one assigned

Labels

documentation

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Docs]: add more DateTime tips

3 participants

@Meir017 @dennisdoomen @jnyrup