Skip to content

Fixed formatting error when checking nullable DateTimeOffset with BeWithin/Before #2312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jnyrup merged 3 commits into from
Sep 22, 2023
Merged

Fixed formatting error when checking nullable DateTimeOffset with BeWithin/Before #2312

jnyrup merged 3 commits into from
Sep 22, 2023

Conversation

@rokklobster
Copy link
Contributor

@rokklobster rokklobster commented Sep 20, 2023 •
edited
Loading

Fix for #2310 - typo in format string

IMPORTANT

  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@dennisdoomen dennisdoomen changed the title #2310 - fix Fixed formatting error when checking nullable DateTimeOffset with BeWithin/Before Sep 20, 2023
jnyrup
jnyrup approved these changes Sep 20, 2023
View reviewed changes
dennisdoomen
dennisdoomen requested changes Sep 20, 2023
View reviewed changes
jnyrup
jnyrup reviewed Sep 21, 2023
View reviewed changes
ITaluone
ITaluone reviewed Sep 21, 2023
View reviewed changes
jnyrup
jnyrup approved these changes Sep 21, 2023
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for reporting and fixing this ❤️

@rokklobster
Copy link
Contributor Author

rokklobster commented Sep 21, 2023

image
@dennisdoomen, @jnyrup, is it something new? I saw it failed several times, but none of fails was because of added code.
Should I do something else? Or can someone help with merging the PR?

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Sep 21, 2023

Please rebase to onto current develop

@github-actions
Copy link

github-actions bot commented Sep 21, 2023

Qodana for .NET

It seems all right 👌

No new problems were found according to the checks applied

💡 Qodana analysis was run in the pull request mode: only the changed files were checked

View the detailed Qodana report

To be able to view the detailed Qodana report, you can either:

  1. Register at Qodana Cloud and configure the action
  2. Use GitHub Code Scanning with Qodana
  3. Host Qodana report at GitHub Pages
  4. Inspect and use qodana.sarif.json (see the Qodana SARIF format for details)

To get *.log files or any other Qodana artifacts, run the action with upload-result option set to true,
so that the action will upload the files as the job artifacts:

      - name: 'Qodana Scan'
        uses: JetBrains/qodana-action@v2023.2.6
        with:
          upload-result: true
Contact Qodana team

Contact us at qodana-support@jetbrains.com

@jnyrup jnyrup merged commit e5bcccf into fluentassertions:develop Sep 22, 2023
@jnyrup jnyrup linked an issue Sep 22, 2023 that may be closed by this pull request
BeWithin().Before for DateTimeOffset? fails with formatting error when value is null #2310
Closed
@rokklobster rokklobster deleted the 2310-fix branch September 22, 2023 07:40
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
0042108 
…BeWithin`/`Before` (fluentassertions#2312)
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
d664373 
…BeWithin`/`Before` (fluentassertions#2312)
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Jul 14, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
b3073f1 
…BeWithin`/`Before` (fluentassertions#2312)
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
950a2a4 
…BeWithin`/`Before` (fluentassertions#2312)
jnyrup pushed a commit to jnyrup/fluentassertions that referenced this pull request Aug 18, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
88c2b12 
…BeWithin`/`Before` (fluentassertions#2312)
jnyrup pushed a commit that referenced this pull request Sep 9, 2024
@rokklobster @jnyrup
Fixed formatting error when checking nullable DateTimeOffset with `…
fd159d4 
…BeWithin`/`Before` (#2312)
This was referenced Jul 21, 2025
Closed
Closed
This was referenced Dec 21, 2025
Closed
Open
Open
Closed
Open
Closed
Open
Closed
Closed
Open
Closed
Merged
Closed
Closed
Open
This was referenced Dec 29, 2025
Open
Closed
Closed
Open
Open
This was referenced Jan 5, 2026
Open
Open
Open
Merged
Closed
Merged
Open
This was referenced Jan 14, 2026
Closed
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dennisdoomen dennisdoomen dennisdoomen approved these changes

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@ITaluone ITaluone ITaluone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

bug

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

BeWithin().Before for DateTimeOffset? fails with formatting error when value is null

5 participants

@rokklobster @IT-VBFK @dennisdoomen @jnyrup @ITaluone