Skip to content

Removed all support for DataSet, DataTable, DataRow and such #2267

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dennisdoomen merged 1 commit into from
Aug 27, 2023
Merged

Removed all support for DataSet, DataTable, DataRow and such #2267

dennisdoomen merged 1 commit into from
Aug 27, 2023

Conversation

@dennisdoomen
Copy link
Member

@dennisdoomen dennisdoomen commented Aug 19, 2023

This was moved to a new repository and package https://github.com/fluentassertions/fluentassertions.datasets

IMPORTANT

  • If the PR touches the public API, the changes have been approved in a separate issue with the "api-approved" label.
  • The code complies with the Coding Guidelines for C#.
  • The changes are covered by unit tests which follow the Arrange-Act-Assert syntax and the naming conventions such as is used in these tests.
  • If the PR adds a feature or fixes a bug, please update the release notes with a functional description that explains what the change means to consumers of this library, which are published on the website.
  • If the PR changes the public API the changes needs to be included by running AcceptApiChanges.ps1 or AcceptApiChanges.sh.
  • If the PR affects the documentation, please include your changes in this pull request so the documentation will appear on the website.
    • Please also run ./build.sh --target spellcheck or .\build.ps1 --target spellcheck before pushing and check the good outcome

@dennisdoomen dennisdoomen self-assigned this Aug 19, 2023
@github-actions
Copy link

github-actions bot commented Aug 19, 2023 •
edited
Loading

Qodana for .NET

20 new problems were found

Inspection name Severity Problems
Potentially misleading parameter name in lambda or local function 🔶 Warning 1
Use raw string ◽️ Notice 14
Literal length can be reduced by using verbatim string ◽️ Notice 3
Use preferred body style (convert into property, indexer, or event with preferred body style) ◽️ Notice 2

💡 Qodana analysis was run in the pull request mode: only the changed files were checked
☁️ View the detailed Qodana report

Contact Qodana team

Contact us at qodana-support@jetbrains.com

@IT-VBFK
Copy link
Contributor

IT-VBFK commented Aug 19, 2023

On the road to v7? 🎉

@jnyrup
Copy link
Member

jnyrup commented Aug 19, 2023

On the road to v7? 🎉

We will soon release 6.12 and then start working on v7

lg2de
lg2de reviewed Aug 20, 2023
View reviewed changes
Tests/FluentAssertions.Specs/FluentAssertions.Specs.csproj Outdated
<ProjectReference Include="..\AssemblyB\AssemblyB.csproj" />
</ItemGroup>


Copy link
Contributor

@lg2de lg2de Aug 20, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

@dennisdoomen dennisdoomen force-pushed the Refactor/RemoveDataSet branch from 5e75f80 to 7df3fcb Compare August 23, 2023 18:06
@dennisdoomen dennisdoomen marked this pull request as ready for review August 23, 2023 18:06
@dennisdoomen dennisdoomen requested a review from jnyrup August 23, 2023 18:15
jnyrup
jnyrup reviewed Aug 24, 2023
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more things to remove:

  • ConstraintCollectionEquivalencyStep
  • ConstraintEquivalencyStep
  • 3 references to System.Data.DataSetExtensions

@dennisdoomen dennisdoomen force-pushed the Refactor/RemoveDataSet branch from 7df3fcb to c80ece4 Compare August 27, 2023 15:20
@dennisdoomen dennisdoomen requested a review from jnyrup August 27, 2023 15:23
jnyrup
jnyrup approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@jnyrup jnyrup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A single typo plus Lukas' suggestion.

@dennisdoomen
Removed all support for DataSet, DataTable, DataRow and such
5699913 
This was moved to a new repository and package
@dennisdoomen dennisdoomen force-pushed the Refactor/RemoveDataSet branch from c80ece4 to 5699913 Compare August 27, 2023 15:39
@dennisdoomen dennisdoomen merged commit 0f2a1cb into fluentassertions:develop Aug 27, 2023
@dennisdoomen dennisdoomen deleted the Refactor/RemoveDataSet branch August 27, 2023 16:10
@coveralls
Copy link

coveralls commented Aug 27, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 5991826734

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.04%) to 97.197%
Files with Coverage Reduction New Missed Lines %
Src/FluentAssertions/Equivalency/Selection/MemberToMemberInfoAdapter.cs 2 76.92%
Totals Coverage Status
Change from base Build 5991744790: -0.04%
Covered Lines: 11640
Relevant Lines: 11855
💛 - Coveralls

cmeeren pushed a commit to cmeeren/fluentassertions that referenced this pull request Sep 18, 2023
@dennisdoomen @cmeeren
Removed all support for DataSet, DataTable, DataRow and such (fluenta…
e2c7815 
…ssertions#2267)

This was moved to a new repository and package
@jnyrup jnyrup mentioned this pull request Sep 25, 2023
Merged
7 tasks
This was referenced Jul 21, 2025
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
This was referenced Dec 31, 2025
Closed
Closed
Open
Merged
Open
Open
Open
Closed
Closed
This was referenced Jan 7, 2026
Closed
Closed
Open
Merged
Closed
Merged
Open
Closed
Closed
Merged
Open
Open
Closed
Open
Open
Open
Open
This was referenced Jan 14, 2026
Open
Merged
Closed
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jnyrup jnyrup jnyrup approved these changes

+1 more reviewer

@lg2de lg2de lg2de left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@dennisdoomen dennisdoomen

Labels

breaking change

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@dennisdoomen @IT-VBFK @jnyrup @coveralls @lg2de