Removed the type from the failure message in equivalency checks #1621
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because the equivalency validator will use the expectation to traverse the object graph, the INode.Type property always refers to the type of the node from the perspective of the expectation. But this was sometimes used to refer to the subject's node, causing weird failure messages.
c0bc35c to
93a13a2
Compare
jnyrup
added a commit
to jnyrup/fluentassertions
that referenced
this pull request
Jul 19, 2021
All callers was removed with fluentassertions#1621
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because the equivalency validator will use the expectation to traverse the object graph, the
INode.Typeproperty (and theDescriptionderived from that) always refers to the type of the node from the perspective of the expectation. But this was sometimes used to refer to the subject's node, causing weird failure messages where the type matched the expectation but not the subject.