-
Notifications
You must be signed in to change notification settings - Fork 731
Implemented string upper/lower case assertions #1357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
969e2fe to
80883f9
Compare
|
Continuing the discussion about API naming... How does I recall that I think the test suite would benefit from tests like these to reflect those cases. subject = "A1";
Action act = () => subject.Should().BeUpper();
act.Should().Throw();subject = "a1";
Action act = () => subject.Should().NotBeUpper();
act.Should().NotThrow();and the complementary for |
dennisdoomen
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this enhancement. I've left some suggestions and corrections in-line. Also, would you be willing to update releases.md and strings.md under https://github.com/fluentassertions/fluentassertions/tree/develop/docs/_pages as well?
Tests/FluentAssertions.Specs/Primitives/StringAssertionSpecs.cs
Outdated
Show resolved
Hide resolved
21b036d to
a3f949c
Compare
a3f949c to
f9075b1
Compare
f9075b1 to
cca1d01
Compare
|
jnyrup
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍
Just a few nits, before it's ready to get merged.
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Co-authored-by: Jonas Nyrup <jnyrup@users.noreply.github.com>
Adds the following
Shoulds tostring, to assert its casing:BeUpperNotBeUpperBeLowerNotBeLowerFixes #1356