Skip to content

Add fluent-cap-ctl command to handle add/drop/get/clear capability operations#3162

Merged
cosmo0920 merged 5 commits into
masterfrom
linux-capability-ctl
Nov 17, 2020
Merged

Add fluent-cap-ctl command to handle add/drop/get/clear capability operations#3162
cosmo0920 merged 5 commits into
masterfrom
linux-capability-ctl

Conversation

@cosmo0920

@cosmo0920 cosmo0920 commented Nov 10, 2020

Copy link
Copy Markdown
Contributor

Please review #3155 first.

Which issue(s) this PR fixes:
None. Follows up #3155

What this PR does / why we need it:
Linux capability operation should be handled in Fluentd management command.
This should be unified interface to add/drop/get/clear operations for Ruby executables which are used to execute Fluentd supervisor and worker(s).

Docs Changes:
Needed. I'll send a PR to describe this command.
fluent/fluentd-docs-gitbook#249

Release Note:
Same as title.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920 cosmo0920 force-pushed the linux-capability-ctl branch from 89e34d0 to be43311 Compare November 13, 2020 06:23
@cosmo0920 cosmo0920 marked this pull request as ready for review November 13, 2020 08:19
@cosmo0920 cosmo0920 requested a review from repeatedly November 13, 2020 08:19
@cosmo0920 cosmo0920 force-pushed the linux-capability-ctl branch from 0bfd905 to 42bf09d Compare November 16, 2020 02:01
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920 cosmo0920 force-pushed the linux-capability-ctl branch from 42bf09d to 6e91870 Compare November 16, 2020 02:12
@repeatedly

Copy link
Copy Markdown
Member

fluent-cap-ctl --clear-cap seems to be redundant. Need -cap suffix in the option?

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920

Copy link
Copy Markdown
Contributor Author

fluent-cap-ctl --clear-cap seems to be redundant. Need -cap suffix in the option?

Hmm..., right. I'll remove -cap suffix from --clear-cap option.

@repeatedly

Copy link
Copy Markdown
Member

How about other options? keep -cap is better? I'll leave it to you.

Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
Comment thread lib/fluent/command/cap_ctl.rb Outdated
Signed-off-by: Hiroshi Hatake <hatake@clear-code.com>
@cosmo0920

Copy link
Copy Markdown
Contributor Author

I'll merge this PR after CIs are finishing.

@cosmo0920 cosmo0920 merged commit 210013e into master Nov 17, 2020
@cosmo0920 cosmo0920 deleted the linux-capability-ctl branch November 17, 2020 09:13
bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this pull request Jan 22, 2021
https://build.opensuse.org/request/show/865189
by user coolo + dimstar_suse
updated to version 1.12.0
 see installed CHANGELOG.md
  # v1.12

  ## Release v1.12.0 - 2020/01/05

  ### New feature

  * in_tail: Add `follow_inode` to support log rotation with wild card
    fluent/fluentd#2992
  * in_tail: Handle linux capability
    fluent/fluentd#3155
    fluent/fluentd#3162
  * windows: Add win32 events alternative to unix signals
    fluent/fluentd#3131

  ### Enhancement

  * buffer: Enable metadata comparison optimization on all platform
    fluent/fluentd#3095
  * fluent-plugin-config-formatter: Handle `service_discovery` type
    fluent/fluentd#3178
  * in_http: Add `add_query_params` parameter to add query par
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants