out_file: Temporal fix for broken gzipped files with gzip and append. ref #1903#1995
Merged
Merged
Conversation
… ref #1903 Direct append causes broken gzipped file when Zlib::DataError happens. This patch uses Tempfile for gzip compression to avoid broken compression. Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
Member
Author
|
@nurse How about this code? |
nurse
approved these changes
May 22, 2018
repeatedly
added a commit
that referenced
this pull request
Feb 25, 2020
Recent fluentd doesn't have thread interruption issue. Signed-off-by: Masahiro Nakagawa <repeatedly@gmail.com>
repeatedly
added a commit
that referenced
this pull request
Feb 26, 2020
out_file: Revert #1995 changes
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Direct append causes broken gzipped file when Zlib::DataError happens.
This patch uses Tempfile for gzip compression to avoid broken compression.
Signed-off-by: Masahiro Nakagawa repeatedly@gmail.com