refactor: use HexFormat for digest encoding#772
Merged
hectorvent merged 1 commit intoMay 12, 2026
Conversation
Signed-off-by: Vinod Kumar <codingkiddo@gmail.com>
hectorvent
approved these changes
May 12, 2026
hectorvent
left a comment
Collaborator
There was a problem hiding this comment.
Hi @codingkiddo,
Thank you for your contribution.
Contributor
Author
|
Thank you for the review and quick merge @hectorvent... Happy to contribute to Floci, and I’ll continue exploring the project for more focused improvements. |
Arthur-0896
pushed a commit
to Arthur-0896/floci
that referenced
this pull request
May 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces manual byte-to-hex conversion using
StringBuilderandString.format("%02x", ...)with the standard JDKHexFormatAPI.This keeps the same lowercase/no-delimiter hex output while making the digest encoding code simpler and more readable.
Why
Floci targets modern Java, so
HexFormatis available and is a better fit for byte-to-hex conversion than manually formatting each byte.Testing
./mvnw clean package -DskipTests./mvnw test -Dtest=ApiGatewayAuthorizerContextIntegrationTest./mvnw testFull test result: