use shared CustomAmountInput, dont allow too many decimals#1413
Merged
use shared CustomAmountInput, dont allow too many decimals#1413
Conversation
mholtzman
requested changes
Feb 9, 2023
Collaborator
mholtzman
left a comment
There was a problem hiding this comment.
the erc-20 changes look good, but the formatting stuff is still a little confusing to me (eg is the component called CustomAmountInput actually focused on tokens?). I think the display logic in general needs a little high-level re-thinking and that might take a little time to get right. can we try, if possible, to avoid as much as refactoring here as we can in the meantime?
app/tray/Account/Requests/TransactionRequest/TxMainNew/overview.js
Outdated
Show resolved
Hide resolved
mholtzman
reviewed
Feb 10, 2023
mholtzman
approved these changes
Feb 14, 2023
wakamex
pushed a commit
to wakamex/framed
that referenced
this pull request
Mar 2, 2026
…1413) * use shared CustomAmountInput, dont allow too many decimals * update the name of component * rename test file * merge into develop
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.