normalize transaction chain id to handle non-standard chain ids and r…#1411
Merged
goosewobbler merged 4 commits intodevelopfrom Feb 14, 2023
Merged
normalize transaction chain id to handle non-standard chain ids and r…#1411goosewobbler merged 4 commits intodevelopfrom
goosewobbler merged 4 commits intodevelopfrom
Conversation
…espond with proper errors
goosewobbler
previously approved these changes
Feb 14, 2023
Contributor
goosewobbler
left a comment
There was a problem hiding this comment.
Couple of nits but LGTM otherwise
Collaborator
Author
fixed |
goosewobbler
approved these changes
Feb 14, 2023
wakamex
pushed a commit
to wakamex/framed
that referenced
this pull request
Mar 2, 2026
floating#1411) Co-authored-by: goosewobbler <432005+goosewobbler@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…espond with proper errors