Skip to content

press enter to save token#1403

Merged
mholtzman merged 6 commits intodevelopfrom
enter-to-save-token
Feb 7, 2023
Merged

press enter to save token#1403
mholtzman merged 6 commits intodevelopfrom
enter-to-save-token

Conversation

@mholtzman
Copy link
Copy Markdown
Collaborator

No description provided.

@mholtzman mholtzman requested a review from Jamchello February 7, 2023 13:43
@Jamchello
Copy link
Copy Markdown
Contributor

Do we want the highlight on the button here?
image

@mholtzman
Copy link
Copy Markdown
Collaborator Author

Do we want the highlight on the button here?

when does this happen, when pressing enter?

@Jamchello
Copy link
Copy Markdown
Contributor

Do we want the highlight on the button here?

when does this happen, when pressing enter?

When the screen opens

@mholtzman mholtzman merged commit 7e4f5de into develop Feb 7, 2023
@mholtzman mholtzman deleted the enter-to-save-token branch February 7, 2023 17:51
wakamex pushed a commit to wakamex/framed that referenced this pull request Mar 2, 2026
* press enter to save token

* fix it all

* make components functional, add tests

* focus button instead of using document listener

* handle key press on all input elements

* fix notify data, remove outline on focus
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants