Conversation
mholtzman
reviewed
Feb 6, 2023
| origin: payload._origin, | ||
| approvals: [], | ||
| feesUpdatedByUser: feesUpdated || false, | ||
| feesUpdatedByUser: false, |
Collaborator
There was a problem hiding this comment.
@Jamchello can you explain this change? seems like we're changing the functionality here
Contributor
Author
There was a problem hiding this comment.
when the fees are updated by frame internally, this feesUpdated value is set to true - it is not indicative of the user updating the fees!
mholtzman
approved these changes
Feb 7, 2023
wakamex
pushed a commit
to wakamex/framed
that referenced
this pull request
Mar 2, 2026
* set feesUpdatedByUser as false when tx request comes in * correctly label who set gas fees
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.