Skip to content

update approval summary to show unlimited approvals#1400

Merged
mholtzman merged 2 commits intodevelopfrom
show-unlimited-approval
Feb 10, 2023
Merged

update approval summary to show unlimited approvals#1400
mholtzman merged 2 commits intodevelopfrom
show-unlimited-approval

Conversation

@mholtzman
Copy link
Copy Markdown
Collaborator

@mholtzman mholtzman commented Feb 2, 2023

image

@mholtzman mholtzman requested a review from Jamchello February 7, 2023 13:55
@Jamchello
Copy link
Copy Markdown
Contributor

Do we want the approximation '~' here before unlimited?

@mholtzman
Copy link
Copy Markdown
Collaborator Author

Do we want the approximation '~' here before unlimited?

I think it works a little better without it here as this is the section that shows a natural language overview

@Jamchello
Copy link
Copy Markdown
Contributor

LGTM

@mholtzman mholtzman merged commit 13e334d into develop Feb 10, 2023
@mholtzman mholtzman deleted the show-unlimited-approval branch February 10, 2023 19:07
wakamex pushed a commit to wakamex/framed that referenced this pull request Mar 2, 2026
* update approval summary to show unlimited approvals

* update hardhat token approval script
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants