Skip to content

remove reload signer button for hot signers#1398

Merged
mholtzman merged 1 commit intodevelopfrom
hide-reload
Feb 1, 2023
Merged

remove reload signer button for hot signers#1398
mholtzman merged 1 commit intodevelopfrom
hide-reload

Conversation

@mholtzman
Copy link
Copy Markdown
Collaborator

No description provided.

// TODO: create well-defined signer states that drive these UI features
const canReconnect =
this.props.type !== 'trezor' || status === 'disconnected' || status.includes('reconnect')
// const canReconnect =
Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cleanup?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wanted to leave this piece just as guidance for future changes. can easily get rid of it too though

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah, don't mind at all if it's purposeful 👍

@mholtzman mholtzman merged commit b2558db into develop Feb 1, 2023
@mholtzman mholtzman deleted the hide-reload branch February 1, 2023 21:58
wakamex pushed a commit to wakamex/framed that referenced this pull request Mar 2, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants