Conversation
| const renderActionOverview = (action, index) => { | ||
| const { id = '', data } = action | ||
| const key = id + index | ||
| const [, actionType] = id.split(':') |
There was a problem hiding this comment.
the idea here was to separate out the action class and action type so that we can have components that handle all the actions for one class, ie erc20 stuff. this pattern works for now but lets at least keep the concept of the action class so that as this grows we can be flexible
There was a problem hiding this comment.
The actionClass is still there in the id string the same as before? It's just not used atm so I haven't assigned the variable there.
There was a problem hiding this comment.
yeah fair enough. can we just keep the variable there? I think in general that gives visibility in the codebase as opposed to the empty comma syntax. otherwise this all looks good
|
|
||
| function renderRecognizedAction(req) { | ||
| const { recognizedActions: actions = [] } = req | ||
| const GenericOverview = () => ( |
There was a problem hiding this comment.
oh maybe rename this component to something about a contract as well
* address isssues - first pass * destructure in function params * fix decline bug, clean up components * add missing param Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>
No description provided.