Skip to content

Show correct summon shortcut#1369

Merged
floating merged 4 commits intodevelopfrom
show-correct-shortcut
Feb 16, 2023
Merged

Show correct summon shortcut#1369
floating merged 4 commits intodevelopfrom
show-correct-shortcut

Conversation

@goosewobbler
Copy link
Copy Markdown
Contributor

@goosewobbler goosewobbler commented Jan 20, 2023

Different keyboard layouts have different keys mapped for the / key. We can use navigator.keyboard.getLayoutMap to detect the key mapped to / at runtime and adjust our messaging (in the settings panel and onboarding) accordingly.

TODO:

  • Detect key layout
  • Test settings panel
  • Test onboard

@goosewobbler goosewobbler added WIP PRs that are still in progress and not ready for review or merging accessibility labels Jan 20, 2023
@goosewobbler goosewobbler modified the milestones: post-omnichain release, v0.6.0 Jan 24, 2023
@goosewobbler goosewobbler removed this from the v0.6.0 milestone Jan 26, 2023
@floating floating requested a review from mholtzman February 15, 2023 18:13
@floating floating merged commit fb5ef31 into develop Feb 16, 2023
@goosewobbler goosewobbler removed the WIP PRs that are still in progress and not ready for review or merging label Feb 16, 2023
wakamex pushed a commit to wakamex/framed that referenced this pull request Mar 2, 2026
Co-authored-by: Jordan Muir <jordan@frame.sh>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants