Conversation
|
Looks nice, need to fix the Native Currency Name behaviour in this form - when the field is empty it uses the placeholder / default text as the field value |
| }) | ||
| }) | ||
|
|
||
| it('should not save network metadata inside the main network state', () => { |
There was a problem hiding this comment.
I don't think we need this test, this isn't verifying any functionality only checking for static code correctness
There was a problem hiding this comment.
if anything maybe we can (or do) have separate tests that test updating the network somehow and those would fail if this wasn't right
| @@ -87,7 +87,8 @@ describe('rendering', () => { | |||
| name: 'Polygon', | |||
There was a problem hiding this comment.
should we add tests to this file for some of the new fields?
Dealing with this in a separate PR |
* started to add default states & stubs for later * able to configure chain icon & native currency name * validate that chain icon is valid image URL if added * merge into develop * add currencyIcon & networkIcon fields * clean up assignment with destructuring * fix test * one more test fix * fix defaults * address comments Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>
No description provided.