Render accounts if signer disconnected when in expanded view#1345
Merged
goosewobbler merged 6 commits intodevelopfrom Jan 18, 2023
Merged
Render accounts if signer disconnected when in expanded view#1345goosewobbler merged 6 commits intodevelopfrom
goosewobbler merged 6 commits intodevelopfrom
Conversation
Collaborator
|
I don't think we want to render the accounts in the signer view, this will mess up the navigation. probably it's better to just navigate back to the main accounts panel if a signer is removed |
Collaborator
|
I think this implementation will still cause the "back" button from the account screen to go back to the signer. maybe @floating has a better idea of how the nav works specifically but I think the idea here is when we remove a signer (most likely in the |
Contributor
Author
|
@mholtzman something like EDIT: prototyped, looking at tests |
floating
reviewed
Jan 17, 2023
mholtzman
approved these changes
Jan 18, 2023
wakamex
pushed a commit
to wakamex/framed
that referenced
this pull request
Mar 2, 2026
…g#1345) * render Accounts if no signer * nav to accounts instead of rendering accounts * clear nav items for a given signer * add test * fix test * move navClearSigner invocation Co-authored-by: goosewobbler <goosewobbler@pm.me>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you disconnect a signer when in expanded view the current behaviour is to render null - we should render the accounts.