Merged
Conversation
mholtzman
requested changes
Jan 4, 2023
app/tray/Account/Account/Requests/TransactionRequest/TxMainNew/overview.js
Outdated
Show resolved
Hide resolved
mholtzman
reviewed
Jan 5, 2023
app/tray/Account/Account/Requests/SignTypedDataRequest/index.js
Outdated
Show resolved
Hide resolved
mholtzman
requested changes
Jan 13, 2023
ab84531 to
a1a4b83
Compare
mholtzman
reviewed
Jan 13, 2023
mholtzman
reviewed
Jan 16, 2023
test/app/tray/Account/Requests/TransactionRequest/index.test.js
Outdated
Show resolved
Hide resolved
mholtzman
reviewed
Jan 19, 2023
mholtzman
previously approved these changes
Jan 19, 2023
6393120 to
c887375
Compare
mholtzman
approved these changes
Jan 19, 2023
wakamex
pushed a commit
to wakamex/framed
that referenced
this pull request
Mar 2, 2026
* idea coming together * assign type a level higher - need to complete ability to change value * started to add logic for updating the message to sign * need to fix re-rendering * flow first pass done * tidying * starting to split * refactoring * add back handlers to Provider * refactoring the new component - need to fix weird double click bug * remove use of amount state variable * useCopiedMessage hook & tests added * started working on tests - lunch break! * finished useCountdown hook testing * test that it re-renders every second * use capitalize, remove test data * add some tests for identify * finish rebase, update test * tidied & refactored the request rendering slightly * add req to test cases * using a dictionary to get the componen * use dictionary for modules * requestComponents => requests * dont crash app when a request is not found... * fix test for updateTypedDataRequest * update tests for useCountdown * update tests, fix a couple of display issues * add test for Countdown, use example component for hook test * working for decimals * final comments round-up * single max defined, fix merge issue from types Co-authored-by: Matt Holtzman <matt.holtzman@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.