Skip to content

Issue 1640 - Move sync account from menu to preferences#41

Merged
flerda merged 1 commit intoflerda:v2.1-devfrom
hssm:Issue1640
Jan 30, 2013
Merged

Issue 1640 - Move sync account from menu to preferences#41
flerda merged 1 commit intoflerda:v2.1-devfrom
hssm:Issue1640

Conversation

@hssm
Copy link
Copy Markdown

@hssm hssm commented Jan 28, 2013

As per Issue 1640, this removes the menu option "Sync account" and instead places it in Preferences -> General -> Synchronization.

I don't know if launching an activity from the preferences screen is a bad idea. I'm still new to this Android stuff, so any feedback is appreciated.

@ghost ghost assigned flerda Jan 29, 2013
@flerda
Copy link
Copy Markdown
Owner

flerda commented Jan 29, 2013

A couple of comments above.
In terms of starting an activity, I think it is maybe a bit too much, but let's do that for now.
In the long term, I think having a dialog would be better maybe?

@hssm
Copy link
Copy Markdown
Author

hssm commented Jan 29, 2013

Yes, a dialog would be better. I wasn't certain how to go about doing it since the activity is used elsewhere (when you first sync, signup). Would we replace all of it with the same dialog?

@flerda
Copy link
Copy Markdown
Owner

flerda commented Jan 29, 2013

Probably it would make sense to use the same dialog everywhere.
Right now when you try to sync, you are prompted with the activity and you need to press back and sync again, while, if it were a dialog, we could just continue after the user is signed in.

Let's do that at a later time.

@flerda
Copy link
Copy Markdown
Owner

flerda commented Jan 30, 2013

Let's do this for now and iterate on the strings and the hkey/username issue.

flerda added a commit that referenced this pull request Jan 30, 2013
Issue 1640 - Move sync account from menu to preferences
@flerda flerda merged commit 2d6462b into flerda:v2.1-dev Jan 30, 2013
@hssm
Copy link
Copy Markdown
Author

hssm commented Jan 30, 2013

Sure. They're small changes. I was just about to get to them. Mind if I send another pull request in a bit?

@flerda
Copy link
Copy Markdown
Owner

flerda commented Jan 30, 2013

Please do sent pull requests at any time!
Thanks for all the help and contributions to the project.

flerda added a commit that referenced this pull request May 18, 2013
Persist ints and force input type to integer in NumberRangePreference.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants