Issue 1640 - Move sync account from menu to preferences#41
Issue 1640 - Move sync account from menu to preferences#41flerda merged 1 commit intoflerda:v2.1-devfrom hssm:Issue1640
Conversation
|
A couple of comments above. |
|
Yes, a dialog would be better. I wasn't certain how to go about doing it since the activity is used elsewhere (when you first sync, signup). Would we replace all of it with the same dialog? |
|
Probably it would make sense to use the same dialog everywhere. Let's do that at a later time. |
|
Let's do this for now and iterate on the strings and the hkey/username issue. |
Issue 1640 - Move sync account from menu to preferences
|
Sure. They're small changes. I was just about to get to them. Mind if I send another pull request in a bit? |
|
Please do sent pull requests at any time! |
Persist ints and force input type to integer in NumberRangePreference.
As per Issue 1640, this removes the menu option "Sync account" and instead places it in Preferences -> General -> Synchronization.
I don't know if launching an activity from the preferences screen is a bad idea. I'm still new to this Android stuff, so any feedback is appreciated.