Fix timeboxing and clean up old session code#36
Merged
flerda merged 1 commit intoflerda:v2.1-devfrom Jan 29, 2013
hssm:timebox
Merged
Fix timeboxing and clean up old session code#36flerda merged 1 commit intoflerda:v2.1-devfrom hssm:timebox
flerda merged 1 commit intoflerda:v2.1-devfrom
hssm:timebox
Conversation
Owner
|
Thanks. |
flerda
added a commit
that referenced
this pull request
Jan 29, 2013
Fix timeboxing and clean up old session code.
Author
|
I'll try to think of a way to do it without those manual +/- reps. I think it does increment on answering but the initial dummy card is skewing the rep count. It might just be a matter of starting the timebox counter after that point. |
Owner
|
Feel free to get in touch if you want to discuss a possible solution at some point. |
flerda
added a commit
that referenced
this pull request
Apr 20, 2013
Add Travis CI build status to README file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes update the timeboxing behaviour so it works like on the desktop client and fixes Issue 1355.
Since sessions were removed in Anki 2 and timeboxing was closely related to that feature in the old version, I've taken the opportunity to remove anything related to sessions as well. I've left some of the
studyoptions_*strings since I think they might be of use as filtering selections later on.One thing to note about this commit:
The rep count is incremented whenever the next card is fetched, which can be seen in DeckTask.doInBackgroundAnswerCard(). That's good so far. However, AnkiDroid appears to answer a "dummy" card when it first starts a review session (see the end of Reviewer.onCreate()). This prematurely increments the rep count, resulting in the first timebox being 1 more than it actually is and having one less rep for the final rep.
In both cases, I've manually accounted for the extra and missing reps at the start and end. It doesn't feel like the best solution, but it's the simplest I could come up with.