Merged
Conversation
function doesn't escape forward slashes when serializing. Android's org.json.JSONObject.toString() function does escape them. That means that when we save some card templates (frequently having tags that have a forward slash when closing) we might be breaking them.
Author
|
hmmm, I did push -f, I hope it didn't mess up things on your side. |
Owner
|
"git push -f" is the right command on a review branch, since nobody should be merge that branch until it is reviewed. |
flerda
added a commit
that referenced
this pull request
Apr 20, 2013
Refresh to Travis CI configuration.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The commit's message should explain what this is about. Not sure whether it is an actual problem though, but better be safe. I discovered it comparing db dumps from ankidroid and anki. Maybe we should write a utility that does that, it's quite manual labour.