builder: add upload-artifact flag to skip uploading artifacts#174
Merged
bilelmoussaoui merged 1 commit intoflatpak:masterfrom Jan 21, 2024
Merged
Conversation
Member
|
The change looks good to me! thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About a month ago GitHub made a breaking change to upload-artifact and download-artifact https://github.blog/changelog/2023-12-14-github-actions-artifacts-v4-is-now-generally-available/
TLDR artifacts uploaded with v3 can't be downloaded with v4 and vise-versa.
The flatpak-builder automatically uploads the artifact it builds using v3, because it's still using 1.X.X of https://www.npmjs.com/package/@actions/artifact?activeTab=readme and I ran into this pain-point when trying to migrate our CI across the board PCSX2/pcsx2#10431
This contribution provides a non-breaking migration path for consumers so they can handle the uploading of the artifact themselves and skip the redundant v3 upload. This may be useful for other reasons as well:
This repo should probably migrate to v2 of @actions/artifact eventually, but that would require a major release as it's a breaking change for anyone using v3 to download them -- this isn't something I wanted to get involved with.