Skip to content

CI: migrate to upload-artifact@v4 and download-artifact@v4#10431

Merged
xTVaser merged 7 commits intomasterfrom
dependabot/github_actions/actions/upload-artifact-4
Jan 6, 2024
Merged

CI: migrate to upload-artifact@v4 and download-artifact@v4#10431
xTVaser merged 7 commits intomasterfrom
dependabot/github_actions/actions/upload-artifact-4

Conversation

@dependabot
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 18, 2023

Bumps actions/upload-artifact from 3 to 4.

Release notes

Sourced from actions/upload-artifact's releases.

v4.0.0

What's Changed

The release of upload-artifact@v4 and download-artifact@v4 are major changes to the backend architecture of Artifacts. They have numerous performance and behavioral improvements.

For more information, see the @​actions/artifact documentation.

New Contributors

Full Changelog: actions/upload-artifact@v3...v4.0.0

v3.1.3

What's Changed

Full Changelog: actions/upload-artifact@v3...v3.1.3

v3.1.2

  • Update all @actions/* NPM packages to their latest versions- #374
  • Update all dev dependencies to their most recent versions - #375

v3.1.1

  • Update actions/core package to latest version to remove set-output deprecation warning #351

v3.1.0

What's Changed

Commits

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

@dependabot dependabot bot added Dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code labels Dec 18, 2023
@github-actions github-actions bot added Build | Project System and removed Dependencies Pull requests that update a dependency file labels Dec 18, 2023
dependabot bot and others added 4 commits December 21, 2023 22:25
@dependabot @xTVaser
Bump actions/upload-artifact from 3 to 4
e8bec0a 
Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot @xTVaser
Bump actions/download-artifact from 3 to 4
84f31e2 
Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@xTVaser
github: group github actions updates going forward
87747e1
@xTVaser
ci: update to labeler@v5
fdaccee
@xTVaser xTVaser force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 2804599 to fdaccee Compare December 22, 2023 05:51
@xTVaser xTVaser mentioned this pull request Dec 22, 2023
Closed
@xTVaser
Copy link
Member

xTVaser commented Dec 22, 2023 •
edited
Loading

Tested here https://github.com/xTVaser/pcsx2-rr/releases/tag/v1.4.11 seems to work fine, no idea where the flatpak gets uploaded to the release, because linux_build_flatpak.yml has no upload-artifact step. So maybe it's setup to only work on PCSX2/pcsx2 / handled by one of the flatpak actions?

This also exposed an issue in the PR artifacts -- v5 forbids duplicate artifact keys, and all windows variants were uploading and overwriting the same artifact name. Now cmake/msvc/clang/sse4/avx2 combinations should be separate artifacts. https://github.com/xTVaser/pcsx2-rr/actions/runs/7296017784/job/19883221584

Also updated the labeler workflow to the new v5 config file format, tested here xTVaser#128 so i wouldn't expect it to explode.

One nice feature about the v4 upload-artifacts if you didn't know is you can finally download them while a workflow is partially complete (ie. you can download artifacts from workflow A while B and C are still running)

@xTVaser xTVaser force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from c72982d to 7077367 Compare December 22, 2023 06:36
@xTVaser xTVaser force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 39ed1df to 28740a1 Compare January 4, 2024 04:31
@xTVaser xTVaser force-pushed the dependabot/github_actions/actions/upload-artifact-4 branch from 28740a1 to e4572f7 Compare January 4, 2024 04:49
@xTVaser
Copy link
Member

xTVaser commented Jan 6, 2024 •
edited
Loading

I think this is good to go, did another test release after fixing artifact names and they match the current releases format:
image
image

I don't think there will be any issues when it comes to the flatpak cron job. I'm not 100% sure how the flatpak cli works but i couldn't find any explicit passing of "here's the flatpak i want to publish" so I assume it just uploads whatever it finds in the current directory.

This is why i moved the upload-artifact to after the flatpak/flatpak-github-actions/flat-manager execution and checked that their action code does no downloading of the artifact that it previously uploaded https://github.com/flatpak/flatpak-github-actions/blob/master/flat-manager/index.js

@xTVaser xTVaser changed the title Bump actions/upload-artifact from 3 to 4 ci: migrate to upload-artifact@v4 and download-artifact@v4 Jan 6, 2024
@xTVaser xTVaser changed the title ci: migrate to upload-artifact@v4 and download-artifact@v4 CI: migrate to upload-artifact@v4 and download-artifact@v4 Jan 6, 2024
@xTVaser xTVaser merged commit 7207681 into master Jan 6, 2024
@xTVaser xTVaser deleted the dependabot/github_actions/actions/upload-artifact-4 branch January 6, 2024 20:44
@xTVaser xTVaser mentioned this pull request Jan 6, 2024
Merged
vertver pushed a commit to vertver/pcsx2-gdbserver that referenced this pull request Apr 4, 2024
@dependabot @xTVaser @vertver
CI: migrate to upload-artifact@v4, download-artifact@v4 and labeler@v5 (
9bb838f 
PCSX2#10431)

* Bump actions/upload-artifact from 3 to 4

Bumps [actions/upload-artifact](https://github.com/actions/upload-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/upload-artifact/releases)
- [Commits](actions/upload-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/upload-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* Bump actions/download-artifact from 3 to 4

Bumps [actions/download-artifact](https://github.com/actions/download-artifact) from 3 to 4.
- [Release notes](https://github.com/actions/download-artifact/releases)
- [Commits](actions/download-artifact@v3...v4)

---
updated-dependencies:
- dependency-name: actions/download-artifact
  dependency-type: direct:production
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>

* github: group github actions updates going forward

* ci: update to labeler@v5

* ci: properly differentiate between windows build artifacts on PRs

* ci: workaround flatpak-builder temporarily as well as test fix

* ci: simplify things, just explicitly specify the artifact names in the workflows

---------

Signed-off-by: dependabot[bot] <support@github.com>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Tyler Wilding <xtvaser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@JordanTheToaster JordanTheToaster JordanTheToaster approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Build | Project System github_actions Pull requests that update GitHub Actions code

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@xTVaser @JordanTheToaster