Skip to content
This repository was archived by the owner on May 30, 2023. It is now read-only.

sys-apps/systemd: Update systemd to v245#448

Merged
sayanchowdhury merged 5 commits intoflatcar-master-alphafrom
sayan/upgrade-systemd-to-v245
Jul 21, 2020
Merged

sys-apps/systemd: Update systemd to v245#448
sayanchowdhury merged 5 commits intoflatcar-master-alphafrom
sayan/upgrade-systemd-to-v245

Conversation

@sayanchowdhury
Copy link
Copy Markdown
Contributor

@sayanchowdhury sayanchowdhury commented Jun 29, 2020

Signed-off-by: Sayan Chowdhury sayan.chowdhury2012@gmail.com

sys-apps/systemd: Update systemd to v245

Should be merged along with

How to use

emerge-amd64-usr sys-apps/systemd

Testing done

This is a draft PR to get more 👀 on the PR early.

Update: Perform a local/dev build of the packages and image.

Copy link
Copy Markdown
Contributor

@krnowak krnowak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sayanchowdhury: I have created a krnowak/upgrade-systemd-to-v245 branch, which is based on your work. There I have tried to backport more changes from upstream and document all the Flatcar specific changes in the ebuild. I hope it will make it easier to update this ebuild later. Could you have a look? I haven't yet tested it, though - I have just finished doing it. Some of the Flatcar: comments may look out of date, but I tried to write them in places where we have dropped the changes from upstream, so the comment shows up in the output of diff systemd-9999.ebuild <gentoo_sys_apps_repo_path>/systemd-245.5.ebuild.

Comment thread sys-apps/systemd/systemd-9999.ebuild Outdated
@sayanchowdhury
Copy link
Copy Markdown
Contributor Author

I had a look through it. Thanks for the comments, that would surely make it easier to maintain in the long run. I see you based it on top of systemd-245.5.ebuild, but I did it keeping system-9999 as the base. That should not be a problem though.

Can you also push the changes to this PR so that we can test it.

@krnowak
Copy link
Copy Markdown
Contributor

krnowak commented Jun 30, 2020

Pushed, haven't changed the CROS_WORKON_COMMIT line, though.

Basing on systemd-9999.ebuild shouldn't be a problem, either - currently it only differs in the patches they apply in src_prepare. But we drop this patching code altogether, so it doesn't really matter.

sayanchowdhury and others added 2 commits July 20, 2020 16:43
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
At the same time, try to document all the Flatcar specific changes.

Co-authored-by: Sayan Chowdhury <sayan@kinvolk.io>
@sayanchowdhury sayanchowdhury force-pushed the sayan/upgrade-systemd-to-v245 branch from 79f7c1d to 0ccb3a5 Compare July 20, 2020 11:17
@sayanchowdhury sayanchowdhury marked this pull request as ready for review July 20, 2020 11:28
@sayanchowdhury sayanchowdhury requested a review from a team July 20, 2020 11:29
@sayanchowdhury sayanchowdhury force-pushed the sayan/upgrade-systemd-to-v245 branch from 917b40e to 28a93c4 Compare July 20, 2020 11:55
Copy link
Copy Markdown
Contributor

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.
I can confirm that the network link issue with systemd v245 does not happen with this PR.

Nits below:

Comment thread sys-kernel/bootengine/bootengine-9999.ebuild
Signed-off-by: Sayan Chowdhury <sayan.chowdhury2012@gmail.com>
@sayanchowdhury sayanchowdhury requested review from a team, dongsupark and krnowak July 21, 2020 08:27
@sayanchowdhury sayanchowdhury merged commit ab85865 into flatcar-master-alpha Jul 21, 2020
@sayanchowdhury sayanchowdhury deleted the sayan/upgrade-systemd-to-v245 branch July 21, 2020 09:32
sayanchowdhury added a commit that referenced this pull request Jul 21, 2020
sys-apps/systemd: Update systemd to v245 by sayanchowdhury
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants