engine/update_attempter: init omaha request params#9
Merged
tormath1 merged 1 commit intoflatcar-masterfrom May 27, 2021
Merged
Conversation
pothos
reviewed
May 25, 2021
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 25, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
Contributor
Author
|
For the record, I tried to fix the unittests in my fork (https://github.com/tormath1/update_engine/commit/5552df4e583f6875eafc02bd01063b12c4b2f116) but we now have segfaults 🙃 |
pothos
approved these changes
May 26, 2021
omaha request params were not loaded after a restart if the status of the `update-engine` is set to UPDATE_STATUS_UPDATED_NEED_REBOOT. It leads to ping Omaha server with missing values in the payload and an empty update server url. To not introduce side effect, we duplicated the init code to the "if" section Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
6cc9745 to
9252647
Compare
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 27, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 27, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 27, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 27, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
tormath1
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 27, 2021
related to flatcar/update_engine#9 Signed-off-by: Mathieu Tortuyaux <mathieu@kinvolk.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
omaha request params were not loaded after a restart if the status
of the
update-engineis set to UPDATE_STATUS_UPDATED_NEED_REBOOT.It leads to ping Omaha server with missing values in the payload and
an empty update server url.
To not introduce side effect, we duplicated the init code to the "if"
section
Signed-off-by: Mathieu Tortuyaux mathieu@kinvolk.io
Testing done (WIP)
Booted an image and assert that
update-engineworks as expected with "idle" status and "need reboot" statuscloses flatcar/Flatcar#388