Prefer /boot/coreos only if /boot/coreos/vmlinux-* exists#5
Merged
pothos merged 1 commit intoflatcar-masterfrom May 22, 2020
Merged
Prefer /boot/coreos only if /boot/coreos/vmlinux-* exists#5pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
In case a user or old software created the first_boot flag file under /boot/coreos instead of /boot/flatcar, the update breaks because /boot/coreos exists and is prefered ofer /boot/flatcar when the kernel is written. Make updating more robust by checking if the kernel binaries exist which as least allows the user to create /boot/coreos/first_boot without breaking the system.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
May 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In case a user or old software created the first_boot flag file under
/boot/coreos instead of /boot/flatcar, the update breaks because /boot/coreos
exists and is prefered ofer /boot/flatcar when the kernel is written.
Make updating more robust by checking if the kernel binaries exist which as least
allows the user to create /boot/coreos/first_boot without breaking the system.
How to use
See flatcar/scripts#68
Testing done
Download the qemu image for arm64 from the linked PR above (because the amd64 did reuse the binary package):
sudo sh -c 'echo GROUP=alpha > /etc/flatcar/update.conf'mkdir /boot/coreos; touch /boot/coreos/first_bootcp /usr/share/flatcar/release /tmp; sudo mount --bind /tmp/release /usr/share/flatcar/releaseFLATCAR_RELEASE_VERSION=0.0.0in/usr/share/flatcar/releasesudo systemctl restart update-engineupdate_engine_client -updatels /boot/coreosshould not have a kernel