Only store Omaha XML response for update check#33
Merged
pothos merged 1 commit intoflatcar-masterfrom Dec 13, 2023
Merged
Conversation
2670b28 to
1590e58
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 11, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
2 tasks
The full Omaha XML response is stored to a file for the postinst action, but we only want the response for the initial update check passed this way and not overwrite the file with responses for state reports. Only store the Omaha XML response for the update check and not all of the interaction with the Omaha server.
1590e58 to
dfc4c52
Compare
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 11, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 12, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
krnowak
approved these changes
Dec 13, 2023
Member
krnowak
left a comment
There was a problem hiding this comment.
The changes look alright. Can I assume that the full response was not used for anything else?
Member
Author
The full response file was used when communicating with |
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 13, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 13, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 13, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Dec 13, 2023
This pulls in flatcar/update_engine#33 to fix supplying extension update payloads with a custom base URL in Nebraska.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The full Omaha XML response is stored to a file for the postinst action, but we only want the response for the initial update check passed this way and not overwrite the file with responses for state reports. Only store the Omaha XML response for the update check and not all of the interaction with the Omaha server.
Fixes flatcar/Flatcar#1281
How to use
Backport to Beta
Fixes flatcar/Flatcar#1281
Testing done
From the new image to the new image works with
and does not use the fallback path.
The previous-version file is modified earlier than the full-response file until the update is complete when it gets modified again:
I've also tested it with Nebraska to ensure that only the first response is stored (in Nebraska it varies). This is the case and the update went well without triggering the fallback path (which would not work).
Upload of the payloads was done with
GITHUB_TOKEN=x NOUPLOAD=1 ./upload_package /var/tmp/test/ http://localhost:8000 notused 9999.9.9and then changing the package URL to a local http server reachable by the VM.Here again we see that the modification time behaves as above: