flatcar-postinst: Remove torcx sanity checks#30
Merged
t-lo merged 1 commit intoflatcar-masterfrom Oct 17, 2023
Merged
Conversation
6 tasks
krnowak
reviewed
Oct 17, 2023
This change removes torcx sanity checks in the `flatcar-postinst` post-install script. This allows future major releases to of docker and containerd sysexts instead of torcx without the post-install script breaking. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
e9a8477 to
0734e00
Compare
krnowak
approved these changes
Oct 17, 2023
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 17, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 19, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 19, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 20, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 20, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 23, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 26, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
t-lo
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 27, 2023
Include PR flatcar/update_engine#30 to un-break updates when torcx was removed in favour of sysext. Signed-off-by: Thilo Fromm <thilofromm@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change removes torcx sanity checks in the
flatcar-postinstpost-install script. This allows future major releases to of docker and containerd sysexts instead of torcx without the post-install script breaking.An earlier version of this PR wrapped torcx sanity checks in a version check of the new OS version to be installed. If MAJOR > 3760 then torcx sanity checks are not run; this was removed during review.
If we need to issue updated update_engine releases to older major versions too, e.g. for bug fixes / security fixes, we'll create a branch with a back-port of the respective change.