toolbox: replace rkt with docker for stable/beta/alpha#1
Merged
dongsupark merged 1 commit intoflatcar-masterfrom Mar 5, 2021
Merged
toolbox: replace rkt with docker for stable/beta/alpha#1dongsupark merged 1 commit intoflatcar-masterfrom
dongsupark merged 1 commit intoflatcar-masterfrom
Conversation
Run docker instead of rkt, to avoid security issues. Basically it runs `docker save` and unpacks the layer tarball.
invidian
approved these changes
Oct 5, 2019
Member
invidian
left a comment
There was a problem hiding this comment.
Currently toolbox is broken on edge release and that fixes it, so 👍
dongsupark
pushed a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Mar 5, 2021
Since rkt will be deprecated soon, we should make toolbox run docker instead of rkt. Also delete dependency on `app-emulation/rkt`, and update hyperlinks. It pulls in flatcar/toolbox#1 .
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Run docker instead of rkt, to avoid security issues.
Basically it runs
docker saveand unpacks the layer tarball.