coreos-base/coreos-init: Work around bash regression and handle dd error#948
Merged
coreos-base/coreos-init: Work around bash regression and handle dd error#948
Conversation
This pulls in flatcar/init#97 and flatcar/init#99 to work around a bash regression and add handling for disk write errors.
Contributor
|
The main issue occurs only for Alpha / Beta - I'm fine with backporting only on these branches for the moment. |
|
Build action triggered: https://github.com/flatcar/scripts/actions/runs/5388319452 |
tormath1
approved these changes
Jun 27, 2023
Contributor
tormath1
left a comment
There was a problem hiding this comment.
CI is OK, I locally tested again - it's good to go!
pothos
added a commit
that referenced
this pull request
Jun 27, 2023
coreos-base/coreos-init: Work around bash regression and handle dd error
Member
Author
|
Backported to Alpha and Beta (using |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pulls in
flatcar/init#97
and
flatcar/init#99
to work around a bash regression and add handling for disk write errors.
How to use
Backport to Alpha and Beta, maybe also Stable?
Needs to be done through
initbackport branches for Beta/Stable.Testing done
So far only manual testing. Jenkins test started with Equinix Metal.
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.Closes: flatcar/Flatcar#1059