Conversation
7a108d6 to
283f117
Compare
sdk_container/src/third_party/coreos-overlay/eclass/coreos-kernel.eclass
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/eclass/coreos-kernel.eclass
Outdated
Show resolved
Hide resolved
sdk_container/src/third_party/coreos-overlay/eclass/coreos-kernel.eclass
Show resolved
Hide resolved
| =x11-drivers/nvidia-drivers-550.144.03 ~arm64 | ||
| =x11-drivers/nvidia-drivers-535.230.02 ~arm64 |
There was a problem hiding this comment.
So slight complication here... I believe only 570 builds for arm64 with the kernel+gcc combination we're using - at least that's what I found when adding support for it to nvidia drivers recently.
How about disabling nvidia sysexts for arm64 for the time being, to focus on getting amd64 in shape.
There was a problem hiding this comment.
Ah, right. I was wondering why the ARM builds always fail with compilation errors. I'll disable it for now, which reminds me there currently isn't a way to make a sysext for AMD only. I might need to add another field to the sysext specifier.. Or maybe just skip building the sysext if the package is masked.
283f117 to
edfa185
Compare
edfa185 to
3f23656
Compare
3f23656 to
b2d0e80
Compare
b2d0e80 to
4147f95
Compare
4147f95 to
4dc74ff
Compare
4dc74ff to
692dd85
Compare
692dd85 to
f524441
Compare
|
@chewi thanks for the review! I've just run shellcheck on this PR and hopefully fixed all instances of the bug |
|
It looks good, but something has gone wrong with your rebase. |
|
Happens to me too occasionally. Time for the good old "make a diff to main and add a single patch on top of a new pristine branch forked from main"? |
From Gentoo commit 9fbc01bc73344c66498d3a3ccbf4fff5be10219b
Accept the NVIDIA-r2 license and don't build the NVIDIA tools.
Don't build NVIDIA drivers when the flatcar-nvidia-drivers sysext is loaded, only load the prebuilt modules. Also make the nvidia.service run after the sysexts are merged. Otherwise, it might start building the modules and conflict with the prebuilt drivers sysext.
To be able to use the SLOT syntax, which uses : we need to change the sysext seperator to |.
Needed for the nvidia-persistenced daemon. It's from Gentoo commit e36ce47183552f9fc23556492d70ab4dc5f11e81.
8e6cb31 to
a96ba6d
Compare
|
I just rebased on main and force-pushed, seems to be OK now. |
|
Hello, I have just a comment on the naming -> Rename nvidia-drivers to nvidia-drivers-service - when I started reading, I was expecting to see a systemd service implementation, where there was a systemd nvidia-drivers unit which was renamed to nvidia-drivers-service. Maybe a rename in something that does not contain the suffix |
Okay, so I understand - the Flatcar package name was changed and not the underlying service name, which was left as is for backwards compatibility. It was a little bit confusing as I expected a service name change too. I suppose the naming can be left as is |
|
For a reference, there are also related open PRs for kola and sysext-bakery |
Add prebuilt NVIDIA drivers in a sysext
nvidia-driversfrom portage and build sysexts from the packageRelated PRs:
NVIDIA tests using sysext: mantle #598
NVIDIA runtime modifications to remove
nvidia-smisymlink: sysext-bakery #153How to use
Testing done
Created a build in Jenkins and tested using kola on Azure instances with NVIDIA GPUs
changelog/directory (user-facing change, bug fix, security fix, update)/bootand/usrsize, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.