kola/tests/sysext: add tests for the NVIDIA drivers sysext#598
Merged
danzatt merged 2 commits intoflatcar-masterfrom May 16, 2025
Merged
kola/tests/sysext: add tests for the NVIDIA drivers sysext#598danzatt merged 2 commits intoflatcar-masterfrom
danzatt merged 2 commits intoflatcar-masterfrom
Conversation
0ccbd6f to
dfda189
Compare
jepio
reviewed
Apr 11, 2025
kola/tests/sysext/nvidia.go
Outdated
Comment on lines
+33
to
+42
| storage: | ||
| files: | ||
| - path: /opt/extensions/flatcar-nvidia-drivers/flatcar-nvidia-drivers-{{ .NvidiaDriversVersion }}.raw | ||
| mode: 0644 | ||
| contents: | ||
| source: https://bincache.flatcar-linux.net/images/amd64/9999.9.4+nvidia-drivers-signing/flatcar-nvidia-drivers-{{ .NvidiaDriversVersion }}.raw | ||
| links: | ||
| - path: /etc/extensions/flatcar-nvidia-drivers-{{ .NvidiaDriversVersion }}.raw | ||
| target: /opt/extensions/flatcar-nvidia-drivers/flatcar-nvidia-drivers-{{ .NvidiaDriversVersion }}.raw | ||
| hard: false |
Member
There was a problem hiding this comment.
For "official" sysexts, the way to enable them is to write to /etc/flatcar/enabled-sysext.conf.
Could you rework the test to use that method?
Docs: https://www.flatcar.org/docs/latest/provisioning/sysext/#types-of-systemd-sysext-images
Example in the zfs test:
mantle/kola/tests/sysext/zfs.go
Lines 94 to 97 in fb1dd2f
dfda189 to
a6d08b2
Compare
1 task
tormath1
reviewed
May 13, 2025
36837ab to
ebcc059
Compare
Upgrade Kubernetes version from v1.30.8 to v1.32.2. Switch NVIDIA runtime sysext to newer extensions.flatcar.org link. Signed-off-by: Daniel Zatovic <daniel.zatovic@gmail.com>
c3a971b to
4a8b85e
Compare
tormath1
reviewed
May 15, 2025
Contributor
tormath1
left a comment
There was a problem hiding this comment.
LGTM - I think it should easier to maintain in this format. Thanks!
kola/tests/misc/nvidia.go
Outdated
| c.Fatal(err) | ||
| } | ||
| out := c.MustSSH(m, "/opt/bin/nvidia-smi") | ||
| out := c.MustSSH(m, "/usr/bin/nvidia-smi") |
Contributor
There was a problem hiding this comment.
I think the path is conditioned on sysextMode as well?
4a8b85e to
5d76459
Compare
Signed-off-by: Daniel Zatovic <daniel.zatovic@gmail.com>
5d76459 to
eaf064c
Compare
danzatt
added a commit
to flatcar/scripts
that referenced
this pull request
May 16, 2025
Add prebuilt NVIDIA drivers in a sysext - Add capability to specify per-sysext USE flags and compile different versions of upstream portage nvidia-drivers (including open and non-open variants). - Allow architecture-specific OS-dependent sysexts - Pull `nvidia-drivers` from portage and build sysexts from the package Related PRs: NVIDIA tests using sysext: [mantle #598](flatcar/mantle#598) NVIDIA runtime modifications to remove `nvidia-smi` symlink: [sysext-bakery #153](flatcar/sysext-bakery#153)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tests for NVIDIA drivers sysext