Skip to content

sys-kernel/bootengine: Bump commit for root unlocking service#1787

Merged
pothos merged 3 commits intoflatcar:mainfrom
simoncampion:root-unlock-service
Mar 27, 2024
Merged

sys-kernel/bootengine: Bump commit for root unlocking service#1787
pothos merged 3 commits intoflatcar:mainfrom
simoncampion:root-unlock-service

Conversation

@simoncampion
Copy link
Copy Markdown
Contributor

@simoncampion simoncampion commented Mar 24, 2024

sys-kernel/bootengine: Bump commit for root unlocking service

Bumps bootengine to version in this PR in flatcar/bootengine. Once merged, I'll change the CROS_WORKON_PROJECT and CROS_WORKON_COMMIT in this PR to point to the flatcar-master.

How to use

See this PR.

Testing done

See this PR.

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@simoncampion simoncampion mentioned this pull request Mar 24, 2024
Merged
2 tasks
@simoncampion
Copy link
Copy Markdown
Contributor Author

simoncampion commented Mar 24, 2024

Once review is finished in the bootengine PR (but before merging), we should run CI against the tests in this kola PR, if possible, and check whether the amd64 and arm64 tests for TPM and Tang pass.

@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 27, 2024

I've already merged the mantle PR and since you checked that it passed I would not kick of another long-running build here - we also have nightly builds to check for issues.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Mar 27, 2024 •
edited
Loading

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8464637318

@pothos pothos force-pushed the root-unlock-service branch from bc9ea55 to cb0b81f Compare March 27, 2024 09:28
@pothos pothos merged commit a5364e0 into flatcar:main Mar 27, 2024
pothos added a commit that referenced this pull request Mar 27, 2024
@pothos
Merge pull request #1787 from flatcar/scripts
5722343 
sys-kernel/bootengine: Bump commit for root unlocking service
@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 27, 2024 •
edited
Loading

The last piece now would be to add a new Butane Flatcar config level that allows to use clevis.

@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 27, 2024

Not sure what merge commit ID I was using but it doesn't exist now 😓

@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 27, 2024

Ah, it was the mantle merge commit ID

@simoncampion
Copy link
Copy Markdown
Contributor Author

simoncampion commented Mar 28, 2024

The last piece now would be to add a new Butane Flatcar config level that allows to use clevis.

Happy to open a PR in coreos/butane for that. Should I add it to Flatcar v1.2.0-experimental, in the code and documentation?

@pothos
Copy link
Copy Markdown
Member

pothos commented Mar 28, 2024

Yes, sounds right, and then we could stabilize it?

@simoncampion
Copy link
Copy Markdown
Contributor Author

simoncampion commented Apr 1, 2024

Sounds good. Since adding Clevis support and stabilizing should probably be done in two separate PRs, I opened a first PR to add it to Flatcar v1.2.0-experimental, without stabilizing. @pothos If the changes look good to you, I'll change the PR from draft to ready.

@github-actions github-actions bot mentioned this pull request Apr 22, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@pothos pothos pothos left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@simoncampion @pothos