Skip to content

bootengine: fix kmod-static-nodes#1654

Merged
ader1990 merged 1 commit intomainfrom
ader1990/fix-kmod-static-nodes
Feb 14, 2024
Merged

bootengine: fix kmod-static-nodes#1654
ader1990 merged 1 commit intomainfrom
ader1990/fix-kmod-static-nodes

Conversation

@ader1990
Copy link
Copy Markdown
Contributor

@ader1990 ader1990 commented Feb 13, 2024

Update the bootengine commit id to use the fix from: flatcar/bootengine#85

Fixes: flatcar/Flatcar#1336

Testing done

[Describe the testing you have done before submitting this PR. Please include both the commands you issued as well as the output you got.]

  • Changelog entries added in the respective changelog/ directory (user-facing change, bug fix, security fix, update)
  • Inspected CI output for image differences: /boot and /usr size, packages, list files for any missing binaries, kernel modules, config files, kernel modules, etc.

@github-actions
Copy link
Copy Markdown

github-actions bot commented Feb 13, 2024

Build action triggered: https://github.com/flatcar/scripts/actions/runs/8702461657

Copy link
Copy Markdown
Member

@pothos pothos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A changelog entry in changelog/bugfixes/2024-02-13-TOPIC.md would be good with something like - Resolved problem causing fallout ([bootengine#85](https://github.com/flatcar/bootengine/pull/85))

@ader1990 ader1990 force-pushed the ader1990/fix-kmod-static-nodes branch from 620fa33 to 57b4fbe Compare February 13, 2024 18:36
@ader1990 ader1990 marked this pull request as ready for review February 13, 2024 18:36
@ader1990
Copy link
Copy Markdown
Contributor Author

Note that this issue is present also on Flatcar versions up to 3510 and maybe older versions (I could track it down up to 3510 using a Hyper-V vm. 3374 did not properly boot because of ignition/cloud-init implementation).

Update the bootengine commit id to use the fix from:
flatcar/bootengine#85

Fixes kubevirt vm creation by ensuring that /dev/vhost-net static node gets created
Fixes: flatcar/Flatcar#1336

Signed-off-by: Adrian Vladu <avladu@cloudbasesolutions.com>
@ader1990 ader1990 force-pushed the ader1990/fix-kmod-static-nodes branch from 57b4fbe to 70ad180 Compare February 14, 2024 10:38
@pothos
Copy link
Copy Markdown
Member

pothos commented Feb 14, 2024

We can do a backport by picking the bootengine commit into backport branches like flatcar-3510-backport and then using the latest commit of these branches in the ebuild file when backporting this change.

@ader1990
Copy link
Copy Markdown
Contributor Author

We can do a backport by picking the bootengine commit into backport branches like flatcar-3510-backport and then using the latest commit of these branches in the ebuild file when backporting this change.

I suggest to have this change tested better (a few test iterations of the HEAD) before backporting it to the beta / stable branches. For the moment, I am the only person affected by the kubevirt issue.

Thanks.

@ader1990 ader1990 merged commit f770658 into main Feb 14, 2024
pothos added a commit that referenced this pull request Mar 5, 2024
bootengine: fix kmod-static-nodes
@ader1990
Copy link
Copy Markdown
Contributor Author

Note that this PR has not been backported yet and only Flatcar version >= 3913 has the fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

K8S kubevirt 'allocatable: devices.kubevirt.io/vhost-net: "0"' with Flatcar 3850.0.0+

3 participants