portage update: port check_root to python3 and fix SDK bootstrap#118
Merged
portage update: port check_root to python3 and fix SDK bootstrap#118
Conversation
A newer version of catalyst seems to be actually gzipping the CONTENTS files, so take this into accout.
The script needs to be ported, because it is importing portage code which became python3 only. The porting I did is likely a lousy job, but at least it stopped failing with some p(yt)hony errors.
The script is written in python2 and it imports portage code. Since the portage is going to become a python3-only code, the script needs porting to python3. It is not the high priority right now, because it seems to be not used by other scripts or jenkins.
sayanchowdhury
approved these changes
Feb 12, 2021
dongsupark
approved these changes
Feb 12, 2021
sayanchowdhury
added a commit
that referenced
this pull request
Feb 15, 2021
portage update: port check_root to python3 and fix SDK bootstrap
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_root script imports portage code which became python3 only after portage update. Updated portage (or catalyst) also seems to generated gzipped CONTENTS files, so adapt the code to handle that.