dev_container_util.sh: Use the shflags group instead of the default flag#107
Merged
sayanchowdhury merged 1 commit intomainfrom Dec 14, 2020
Merged
dev_container_util.sh: Use the shflags group instead of the default flag#107sayanchowdhury merged 1 commit intomainfrom
sayanchowdhury merged 1 commit intomainfrom
Conversation
The build_image script invokes the create_dev_container function, and passes the `FLAGS_group` as param. Use the param, to generate the binhost URL instead of using the DEFAULT_GROUP which stays as developer always. Fixes: flatcar/Flatcar#298 Signed-off-by: Sayan Chowdhury <sayan@kinvolk.io>
pothos
approved these changes
Dec 14, 2020
sayanchowdhury
added a commit
that referenced
this pull request
Dec 14, 2020
dev_container_util.sh: Use the shflags group instead of the default flag
sayanchowdhury
added a commit
that referenced
this pull request
Dec 14, 2020
dev_container_util.sh: Use the shflags group instead of the default flag
Member
Author
|
Picked to |
pothos
added a commit
that referenced
this pull request
Dec 15, 2020
dev_container_util.sh: Use the shflags group instead of the default flag
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev_container_util.sh: Use the shflags group instead of the default flag
The build_image script invokes the create_dev_container function and
passes the
FLAGS_groupas param. Use the param, to generate thebinhost URL instead of using the DEFAULT_GROUP which stays as developer
always.
Fixes: flatcar/Flatcar#298
Signed-off-by: Sayan Chowdhury sayan@kinvolk.io
Note: Pick the patch to
flatcar-2605andflatcar-2705How to use
Testing done
Built a test container locally with the
--groupparameter and verified the/etc/portage/make.conf