Log list of coredumps with coredumpctl#8
Merged
pothos merged 2 commits intoflatcar-masterfrom Apr 6, 2020
Merged
Conversation
That a program crashed is not visible in the mayday tar ball unless the kernel log is searched for it and users may miss that a program crashed. Include the output of `coredumpctl list` in the tar ball so that the user can see which programs crashed and whether a core dump is still available on the machine for further inspection.
margamanterola
approved these changes
Apr 6, 2020
margamanterola
left a comment
There was a problem hiding this comment.
This LGTM. But, in order to get this to work I needed to:
- Install systemd-coredump
- Run mayday with sudo (at least in Debian, coredumpctl doesn't really do much without root rights).
I tried to find if there's somewhere where tool dependencies are listed or where things that require root rights are documented but I didn't find either... Is this info not stored anywhere?
Member
Author
|
Yes, the instructions in the readme are very basic. I'll add something there. |
dongsupark
approved these changes
Apr 6, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 6, 2020
This pulls in flatcar/mayday#8 to include "coredumpctl list" in the tar ball.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 6, 2020
This pulls in flatcar/mayday#8 to include "coredumpctl list" in the tar ball.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 6, 2020
This pulls in flatcar/mayday#8 to include "coredumpctl list" in the tar ball.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 6, 2020
This pulls in flatcar/mayday#8 to include "coredumpctl list" in the tar ball.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
That a program crashed is not visible in the mayday tar ball unless the
kernel log is searched for it and users may miss that a program crashed.
Include the output of
coredumpctl listin the tar ball so that the usercan see which programs crashed and whether a core dump is still available
on the machine for further inspection.
How to use/test