Skip to content

flatcar-install: support installation on multipath devices#24

Merged
dongsupark merged 1 commit intoflatcar:flatcar-masterfrom
simonello:patch-1
Sep 2, 2020
Merged

flatcar-install: support installation on multipath devices#24
dongsupark merged 1 commit intoflatcar:flatcar-masterfrom
simonello:patch-1

Conversation

@simonello
Copy link
Copy Markdown
Contributor

@simonello simonello commented Aug 27, 2020

Allow installation to multipath target

I got the error "Target block device /dev/mapper/mpatha is not a full disk". I had to change line 360 in the /usr/bin/coreos-install script and add mpath. Now I can install on /dev/mapper/mpatha

flatcar-archive/coreos-overlay#528

How to use

systemctl start multipathd
coreos-install -d /dev/mapper/mpatha

Testing done

it installs and comes up on a reboot.

I got the error "Target block device /dev/mapper/mpatha is not a full disk". I had to change line 360 in the /usr/bin/coreos-install script and add mpath. Now I can install on /dev/mapper/mpatha

flatcar-archive/coreos-overlay#528
@dongsupark dongsupark requested a review from a team August 27, 2020 15:35
@dongsupark dongsupark changed the title Update flatcar-install flatcar-install: support installation on multipath devices Aug 28, 2020
Copy link
Copy Markdown
Member

@dongsupark dongsupark left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR.
The code looks good.
We would also need another PR in coreos-overlay, to pull in the new commit in the init repo.
For now I will let other maintainers have a look as well.

@dongsupark dongsupark merged commit 6523efd into flatcar:flatcar-master Sep 2, 2020
dongsupark pushed a commit to flatcar-archive/coreos-overlay that referenced this pull request Sep 2, 2020
Allow `flatcar-install` to install Flatcar into a multipath target.

Pulls in flatcar/init#24
@dongsupark
Copy link
Copy Markdown
Member

Filed a PR flatcar-archive/coreos-overlay#561

jepio pushed a commit that referenced this pull request Feb 21, 2022
network: don't manage the loopback interface
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants