This repository was archived by the owner on May 30, 2023. It is now read-only.
coreos/config: add fix for perl cross-compilation#1238
Merged
Conversation
Current cross builds of perl segfault on simple operations such as `perl -V`. This appears to be due to the cross-build not getting `-fwrapv -fno-strict-aliasing` passed from the configure script. While we try to get this fixed upstream, we can monkeypatch our old version of perl to fix this. Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
krnowak
approved these changes
Aug 31, 2021
jepio
added a commit
that referenced
this pull request
Aug 31, 2021
coreos/config: add fix for perl cross-compilation
jepio
added a commit
that referenced
this pull request
Aug 31, 2021
coreos/config: add fix for perl cross-compilation
jepio
added a commit
that referenced
this pull request
Aug 31, 2021
coreos/config: add fix for perl cross-compilation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
dev-lang/perl: fix cross-compiled perl segfault.
Current cross builds of perl segfault on simple operations such as
perl -V.This appears to be due to the cross-build not getting
-fwrapv -fno-strict-aliasingpassed from the configure script. While we try to get this fixed upstream, we
can monkeypatch our old version of perl to fix this.
Upstream PR: gentoo/gentoo#22167
Related issue: flatcar/Flatcar#490
How to use
Testing done
Output:
Previously this would result in a segfault.
Added a call to
perl -Vto the dev-container test and ran CI, test passed (previously fail):http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3441/cldsv/