dev-lang/perl: append required cflags when x-compiling#22167
Closed
jepio wants to merge 1 commit intogentoo:masterfrom
Closed
dev-lang/perl: append required cflags when x-compiling#22167jepio wants to merge 1 commit intogentoo:masterfrom
jepio wants to merge 1 commit intogentoo:masterfrom
Conversation
The cross-build system wants to append cflags required by the build to the
'optimize' variable, but doesn't touch the variable when the user overrides it.
Since the ebuild passes '-Doptimize="${CFLAGS}"', we are responsible for
passing the correct flags, so append '-fwrapv -fno-strict-aliasing' to cflags
when we are cross-compiling.
Bug: https://bugs.gentoo.org/811237
Reported-by: Github User DRKV333
Signed-off-by: Jeremi Piotrowski <jpiotrowski@microsoft.com>
Pull Request assignmentSubmitter: @jepio dev-lang/perl: @gentoo/perl Linked bugsBugs linked: 811237 In order to force reassignment and/or bug reference scan, please append Docs: Code of Conduct ● Copyright policy (expl.) ● Devmanual ● GitHub PRs ● Proxy-maint guide |
Collaborator
Pull request CI reportReport generated at: 2021-08-31 09:09 UTC There are existing issues already. Please look into the report to make sure none of them affect the packages in question: |
Member
|
Thank you for the patch and explanation! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug: https://bugs.gentoo.org/811237
Reported-by: Github User DRKV333
Signed-off-by: Jeremi Piotrowski jpiotrowski@microsoft.com