Support both guestinfo.ignition.config and guestinfo.coreos.config as data source#4
Merged
pothos merged 2 commits intoflatcar-masterfrom Apr 23, 2020
Merged
Conversation
The Ignition data and the cloud-config data resides at the same place. There was a name change from coreos.config to ignition.config in upstream Ignition. This means that if only ignition.config is used as guestinfo variable only Ignition configs are currently accepted while both should be supported. Support the ignition.config variables and fall back to coreos.config variables the same way Ignition does, so that the user or a provisioning tool does not need to care which config format is used in the guestinfo variable.
sayanchowdhury
approved these changes
Apr 23, 2020
dongsupark
approved these changes
Apr 23, 2020
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 23, 2020
Pulls in flatcar/coreos-cloudinit#4 to support guestinfo.ignition.config.* variables as data source.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 24, 2020
Pulls in flatcar/coreos-cloudinit#4 to support guestinfo.ignition.config.* variables as data source.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 24, 2020
Pulls in flatcar/coreos-cloudinit#4 to support guestinfo.ignition.config.* variables as data source.
pothos
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Apr 24, 2020
Pulls in flatcar/coreos-cloudinit#4 to support guestinfo.ignition.config.* variables as data source.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Ignition data and the cloud-config data resides at the same place.
There was a name change from coreos.config to ignition.config in upstream
Ignition. This means that if only ignition.config is used as guestinfo
variable only Ignition configs are currently accepted while both should
be supported.
Support the ignition.config variables and fall back to coreos.config
variables the same way Ignition does, so that the user or a provisioning
tool does not need to care which config format is used in the guestinfo
variable.
How to use
Set
guestinfo.ignition.config.*variables in VMware and use the cloud-config format.Testing done