Update to go 1.18, using go modules.#14
Merged
jepio merged 3 commits intoflatcar:flatcar-masterfrom Aug 2, 2022
Merged
Conversation
1 task
Member
|
Thanks for this! I'm really curious how you were able to build this though, when I try it I get: I then tried various I found a way to get it to work with a Other comments:
|
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 3, 2022
This pulls in these PRs: - flatcar/coreos-cloudinit#13 (imdsv2) - flatcar/coreos-cloudinit#14 (go.mod) Since go.mod is now present, rework the ebuild to remove unused bits and enable go module support.
3 tasks
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 4, 2022
This pulls in these PRs: - flatcar/coreos-cloudinit#13 (imdsv2) - flatcar/coreos-cloudinit#14 (go.mod) Since go.mod is now present, rework the ebuild to remove unused bits and enable go module support.
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 4, 2022
This pulls in these PRs: - flatcar/coreos-cloudinit#13 (imdsv2) - flatcar/coreos-cloudinit#14 (go.mod) Since go.mod is now present, rework the ebuild to remove unused bits and enable go module support.
jepio
added a commit
to flatcar-archive/coreos-overlay
that referenced
this pull request
Aug 4, 2022
This pulls in these PRs: - flatcar/coreos-cloudinit#13 (imdsv2) - flatcar/coreos-cloudinit#14 (go.mod) Since go.mod is now present, rework the ebuild to remove unused bits and enable go module support.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Update this tool to go 1.18 and use go modules instead of vendoring.
Removed all the vendored code + replaced it with equivalent go modules - did not need to upgrade any versions, because the vendoring manifest provided what was needed to get the same versions of the code in go modules.
How to use
No changes needed.
Testing done
Built and tested using the scripts included in the repo.
changelog/directory (user-facing change, bug fix, security fix, update)No need, no user-visible change.