Skip to content

dracut: let network-cleanup.service finish before entering the rootfs#27

Merged
pothos merged 1 commit intoflatcar-masterfrom
kai/network-cleanup-wait
Aug 3, 2021
Merged

dracut: let network-cleanup.service finish before entering the rootfs#27
pothos merged 1 commit intoflatcar-masterfrom
kai/network-cleanup-wait

Conversation

@pothos
Copy link
Copy Markdown
Member

@pothos pothos commented Aug 2, 2021

The network-cleanup.service failed when it wasn't fast enough to
complete before the root filesystem is switched:
network-cleanup.service: Current command vanished from the unit file,
execution of the command list won't be resumed.
Similar to the sysroot-boot.service we need to be finished with the
network-cleanup.service before the switch is done.

Add the ordering and conflicts directives as done in
sysroot-boot.service.

How to use

Testing done

Done in http://jenkins.infra.kinvolk.io:8080/job/os/job/manifest/3185/cldsv/ - looks good, in the past I had seen the errors on Azure kola tests some times but of course with plain testing there is no way to know with races whether they are gone

The network-cleanup.service failed when it wasn't fast enough to
complete before the root filesystem is switched:
  network-cleanup.service: Current command vanished from the unit file,
  execution of the command list won't be resumed.
Similar to the sysroot-boot.service we need to be finished with the
network-cleanup.service before the switch is done.

Add the ordering and conflicts directives as done in
sysroot-boot.service.
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Aug 2, 2021
@pothos pothos marked this pull request as ready for review August 2, 2021 15:58
@pothos pothos requested a review from a team August 2, 2021 15:58
Copy link
Copy Markdown
Member

@jepio jepio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems correct

@pothos pothos merged commit c9c42c5 into flatcar-master Aug 3, 2021
@pothos pothos deleted the kai/network-cleanup-wait branch August 3, 2021 08:40
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Aug 3, 2021
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Aug 3, 2021
pothos added a commit that referenced this pull request Aug 12, 2021
dracut: let network-cleanup.service finish before entering the rootfs
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Aug 12, 2021
…witch

This pulls in
flatcar/bootengine#27
from a backport branch "flatcar-2905-backport".
pothos added a commit to flatcar-archive/coreos-overlay that referenced this pull request Aug 12, 2021
…witch

This pulls in
flatcar/bootengine#27
from a backport branch "flatcar-2905-backport".
t-lo pushed a commit to flatcar/scripts that referenced this pull request Apr 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants