minimal-init: Use kmod's modprobe also for simple module loading#113
Merged
pothos merged 1 commit intoflatcar-masterfrom Oct 29, 2025
Merged
minimal-init: Use kmod's modprobe also for simple module loading#113pothos merged 1 commit intoflatcar-masterfrom
pothos merged 1 commit intoflatcar-masterfrom
Conversation
We already use kmod's modprobe for loading drivers from alias entries but still used busybox's modprobe for the three explicit calls. This caused a "Invalid ELF header magic: != ELF" warning being printed while it tries to load the compressed module before uncompressing. While harmless this does not look good and is confusing. Always use kmod's modprobe for module loading. Whether busybox prefers builtins or not is a configuration option and we shouldn't assume it always is configured in a particular way, so an explicit call is best. Fixes flatcar/Flatcar#1934 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 28, 2025
This pulls flatcar/bootengine#113 to fix a kernel boot warning being printed for three modules that are loaded explicitly. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
2 tasks
krnowak
approved these changes
Oct 28, 2025
chewi
approved these changes
Oct 28, 2025
Contributor
chewi
left a comment
There was a problem hiding this comment.
I'm happy, assuming it works. I saw more than 3 instances of the error, but the btrfs dependencies probably triggered several.
Member
Author
|
Looks good now |
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 29, 2025
This pulls flatcar/bootengine#113 to fix a kernel boot warning being printed for three modules that are loaded explicitly. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Oct 29, 2025
This pulls flatcar/bootengine#113 to fix a kernel boot warning being printed for three modules that are loaded explicitly. Signed-off-by: Kai Lueke <kailuke@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We already use kmod's modprobe for loading drivers from alias entries but still used busybox's modprobe for the three explicit calls. This caused a "Invalid ELF header magic: != ELF" warning being printed while it tries to load the compressed module before uncompressing. While harmless this does not look good and is confusing. Always use kmod's modprobe for module loading. Whether busybox prefers builtins or not is a configuration option and we shouldn't assume it always is configured in a particular way, so an explicit call is best.
Fixes flatcar/Flatcar#1934
How to use
Backport to Alpha
Testing done
The messages are gone with the image built from the CI.