dracut: Reduce size with wrappers#108
Merged
pothos merged 1 commit intoflatcar-masterfrom Aug 13, 2025
Merged
Conversation
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 12, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 12, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 12, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
The xfs repair binaries are large and the user might need them manually for the rootfs but at that point we can load them from /usr, too, through a wrapper script. They are not called automatically (fsck.xfs does not exist because the journal is enough for regular recovery). Signed-off-by: Kai Lueke <kailuke@microsoft.com>
Member
Author
|
The tpm2 binary is not created as wrapper because it seems something copies the real binary again after the dracut Ignition module ran? We need to check this in a follow up. |
2 tasks
chewi
approved these changes
Aug 13, 2025
Contributor
chewi
left a comment
There was a problem hiding this comment.
Nice! As you know, I have a plan, but this is a solid win in the meantime.
For tpm2, maybe this whole wrapper setup could move to the debloat module.
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 13, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
Member
Author
I tried that in this PR first but something still ended up placing the binary on top. |
Contributor
probably dracut code? |
Contributor
|
It might be Clevis, but I haven't checked. |
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 13, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
pothos
added a commit
to flatcar/scripts
that referenced
this pull request
Aug 13, 2025
This pulls in flatcar/bootengine#108 Signed-off-by: Kai Lueke <kailuke@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The xfs repair binaries are large and the user might need them manually
for the rootfs but at that point we can load them from /usr, too,
through a wrapper script. They are not called automatically (fsck.xfs
does not exist because the journal is enough for regular recovery).
How to use
Testing done
Ran the wrappers and checked that fsck is not done automatically for xfs.